fix(typescript): timeDifference is not a valid parameter #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the `timeDifference` key from `StrategyOptions` to `State`. This is because `timeDifference` is only used internally in the state object and not passed in by the user in the options parameter to auth-app. The types were not failing previously because the `State` type extends the `StrategyOptions` type. However, `State` is the correct place for this key to live.
gr2m
changed the title
gr2m
added
Type: Bug
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
timeDifferencekey fromStrategyOptionstoState.This is because
timeDifferenceis only used internally in the stateobject and not passed in by the user in the options parameter to
auth-app.
The types were not failing previously because the
Statetype extendsthe
StrategyOptionstype. However,Stateis the correct place forthis key to live.
Closes #199