-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add webhook deliveries APIs #285
Conversation
That's a tricky one, these endpoints are not documented yet, they seem to be tested with a select group of people. Can you make sure it's okay to share this gist in the first place? I have to think about this for a moment, I don't want to add routes to the source code that might still change, because that would cause an unnecessary breaking change. Also these routes might be for internal testing, not meant to be made public yet. I think the right thing to do would be to add an option to pass additional routes that require the app authentication, but I have to think about it for a moment |
I agree, your last proposal sounds to me to be the best solution. I tried to somehow add the route without this PR (because of the beta) but could not find any way to do it. |
Co-authored-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
Thanks for the other two paths. I totally did not realize that was also needed. |
🎉 This PR is included in version 3.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi,
I'm trying to use the new event redelivery api
The request are not working for me because it seams to want to use the installation token when I use the endpoint:
app/hook/deliveries?status=failure
I tried it from a probot app with:
I'm not sure about the other apis, if they need an installation token or an app bearer.
What do you think?