Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates app.js for the handling of an error being thrown by the verify method in webhooks.js #2576

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Nov 15, 2023
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd requested review from gr2m and kfcampbell November 15, 2023 15:56
@gr2m gr2m merged commit b59da80 into main Nov 15, 2023
8 checks passed
@gr2m gr2m deleted the update-app-for-handle-error branch November 15, 2023 16:39
Copy link

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@batflarrow
Copy link

batflarrow commented Dec 19, 2023

Hello,
Can we backport this fix to v2 as well? Happy to open a pr as well.

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 15, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


##### [\`v3.2.1\`](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))
##### [\`v3.2.0\`](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))
##### [\`v3.1.2\`](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 15, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


##### [\`v3.2.1\`](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))
##### [\`v3.2.0\`](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))
##### [\`v3.1.2\`](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 15, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


## [v3.2.1](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))


## [v3.2.0](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))


## [v3.1.2](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 15, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


## [v3.2.1](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))


## [v3.2.0](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))


## [v3.1.2](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 16, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


## [v3.2.1](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))


## [v3.2.0](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))


## [v3.1.2](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Aug 17, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | octokit | 3.1.1 | 3.2.1 |


## [v3.2.1](https://github.com/octokit/octokit.js/releases/tag/v3.2.1)

##### Bug Fixes

-   update rest endpoints ([#2667](octokit/octokit.js#2667)) ([98785f4](octokit/octokit.js@98785f4))


## [v3.2.0](https://github.com/octokit/octokit.js/releases/tag/v3.2.0)

##### Features

-   **security:** Add provenance ([#2653](octokit/octokit.js#2653)) ([a90799a](octokit/octokit.js@a90799a))


## [v3.1.2](https://github.com/octokit/octokit.js/releases/tag/v3.1.2)

##### Bug Fixes

-   updates app.js for the handling of an error being thrown by the verify method in webhooks.js ([#2576](octokit/octokit.js#2576)) ([b59da80](octokit/octokit.js@b59da80))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants