Dev container rework to support OmniSharp changes

[nickfloyd]

These changes are needed so that when working on code spaces and on OmniSharp server will properly start - https://github.com/OmniSharp/omnisharp-vscode#requirements

[timrogers]

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this:

[nickfloyd]

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this.

Yes it starts right away. Odd I've never seen that error. I am assuming steps to repro are:

1. Spin up a code space using this branch
2. Restart OmniSharp.

Validate my assumed steps to repo - perhaps we can pair on it as well some time.

[timrogers]

Does Omnisharp start for you with these changes? It doesn't for me. If I try to run the 'Restart OmniSharp' command for the command palette, I also get an error like this.

Yes it starts right away. Odd I've never seen that error. I am assuming steps to repro are:

1. Spin up a code space using this branch
2. Restart OmniSharp.

Validate my assumed steps to repo - perhaps we can pair on it as well some time.

Exactly. I did that, and that's what I'm seeing. Also worth noting that IntelliSense etc. doesn't work for me.

[timrogers]

I just ran the command because I saw IntelliSense wasn't working and I thought it might help. It seems that all the OmniSharp related commands generated similar errors.

[nickfloyd]

I just ran the command because I saw IntelliSense wasn't working and I thought it might help. It seems that all the OmniSharp related commands generated similar errors.

Interesting... Would you mind sharing what you are seeing in the VS Code "Output" window after the code space is generated?

Generally, you'll see something like, or a OmniSharp "service has started...." :

Thanks for your help and 👀 on this btw... I'd really like to get this DX solid for all contributors.

[timrogers]

I restarted my container and it worked 🤔 What do you think of merging this, and coming back later if we or others run into issues?

[nickfloyd]

release_notes: Adds support to the dev container for OmniSharp