-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to esbuild and tsc instead of pika #603
Conversation
Don't forget to explicitly mark type imports and exports. Whenever an imported value, that is also JS code, is only used as a type, it should be imported as a type, to make sure that it doesn't show up in the build output. All typescript types (except for |
@wolfy1339 I've updated this PR to correctly import types, bumped to the latest version of octokit/tsconfig, and fixed the merge conflict! Hopefully this is good to go now. |
Looks like we're all good now! |
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Replicating octokit/request.js#584 to another repo.
Pika has been deprecated for a while now, and the project has now been archived, and because of that the released npm package is missing most of the files generated by the build step.
Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle
Uses the TypeScript compiler to generate the types.
Behavior
Before the change?
dist-node
,dist-types
,dist-web
... even though they are generated correctly.After the change?
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Maintenance