Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: fetch fails on latest Node.js when sending a body #570

Closed
1 task done
codebytere opened this issue Feb 15, 2023 · 1 comment · Fixed by #571
Closed
1 task done

[BUG]: fetch fails on latest Node.js when sending a body #570

codebytere opened this issue Feb 15, 2023 · 1 comment · Fixed by #571
Labels
released Type: Bug Something isn't working as documented

Comments

@codebytere
Copy link
Contributor

What happened?

whatwg/fetch#1457 introduced a required duplex option when sending a body in fetch calls. This results in errors like the following:

Uncaught TypeError: RequestInit: duplex option is required when sending a body.
    at new Request (node:internal/deps/undici/undici:7090:19)

when fetching via Node.js. Electron was hit with this in latest Node.js in our asset upload logic which falls down to the new requirement. CI error can be seen here.

Versions

Node.js v18.14.0

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@codebytere codebytere added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 15, 2023
This was referenced Feb 15, 2023
Merged
Closed
@wolfy1339 wolfy1339 added Priority: Normal and removed Status: Triage This is being looked at and prioritized Priority: Normal labels Feb 16, 2023
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Mar 24, 2023
gr2m added a commit that referenced this issue May 16, 2023
@gr2m
fix: addsduplex option when sending a body
3df1556 
closes #570
@github-actions
Copy link

🎉 This issue has been resolved in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Type: Bug Something isn't working as documented
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add duplex option when sending a body codebytere/request.js
2 participants
@codebytere @wolfy1339