Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve with url property #27

Merged
merged 4 commits into from
Jan 20, 2019
Merged

resolve with url property #27

merged 4 commits into from
Jan 20, 2019

Commits on Jan 20, 2019

  1. test: resolve with url property

    @gr2m
    gr2m committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    87353f3 View commit details
    Browse the repository at this point in the history

  2. fix: resolve with url property

    @gr2m
    gr2m committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    9379763 View commit details
    Browse the repository at this point in the history

  3. docs(README): result.url

    @gr2m
    gr2m committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    fca799a View commit details
    Browse the repository at this point in the history

  4. test: bypass mocking when testing response.url. 

    this test cannot be mocked with `fetch-mock`. I don’t like to rely on
external websites to run tests, but in this case I’ll make an exception.
The alternative would be to start a local server we then send a request to,
this would only work in Node, so we would need to adapt the test setup, too.
    @gr2m
    gr2m committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    7a0e959 View commit details
    Browse the repository at this point in the history