Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency node-fetch to v3 #422

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 31, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
node-fetch ^2.6.7 -> ^3.0.0 age adoption passing confidence

Release Notes

node-fetch/node-fetch

v3.3.1

Compare Source

Bug Fixes

v3.3.0

Compare Source

Features

v3.2.10

Compare Source

Bug Fixes

v3.2.9

Compare Source

Bug Fixes
  • Headers: don't forward secure headers on protocol change (#​1599) (e87b093)

v3.2.8

Compare Source

Bug Fixes

v3.2.7

Compare Source

Bug Fixes

v3.2.6

Compare Source

Bug Fixes

v3.2.5

Compare Source

Bug Fixes

v3.2.4

Compare Source

Bug Fixes

v3.2.3

Compare Source

Bug Fixes

v3.2.2

Compare Source

Bug Fixes

v3.2.1

Compare Source

Bug Fixes

v3.2.0

Compare Source

Features

v3.1.1

Compare Source

Security patch release

Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.1.0...v3.1.1

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: node-fetch/node-fetch@v3.0.0...v3.1.0

v3.0.0

Compare Source

version 3 is going out of a long beta period and switches to stable

One major change is that it's now a ESM only package
See changelog for more information about all the changes.

v2.6.11

Compare Source

Reverts

v2.6.10

Compare Source

Bug Fixes

v2.6.9

Compare Source

Bug Fixes

v2.6.8

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Aug 31, 2021
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not ready for node-fetch v3, as it's a native ES Module. We will be once the work is done in https://github.com/octokit/octokit-next.js

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from b238c70 to a560a53 Compare September 9, 2021 17:02
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from 83d7029 to 2c51067 Compare September 17, 2021 23:33
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 2c51067 to 47da654 Compare September 20, 2021 16:59
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from e10d809 to 0f3a15b Compare October 4, 2021 16:21
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from d11b9ec to ff1acc2 Compare October 11, 2021 02:09
@mscdex
Copy link

mscdex commented Nov 12, 2021

Just thought I'd say that without this dependency update, modern versions of node are emitting deprecation notices due to node-fetch 2.x's use of a whatwg-url from 2017 that uses new Buffer().

@CumpsD
Copy link

CumpsD commented Jan 28, 2022

This PR is needed to fix actions/github-script#202

@wolfy1339
Copy link
Member

That is not possible at this time. v3 of node-fetch switches to ESM, as discussed in previous comments, and the review comment.

Unfortunately the JS octokit libraries no longer have an active maintainer.

You can read about it in this discussion, subscribe to it for further updates.

@CumpsD
Copy link

CumpsD commented Jan 30, 2022

That is not possible at this time. v3 of node-fetch switches to ESM, as discussed in previous comments, and the review comment.

Unfortunately the JS octokit libraries no longer have an active maintainer.

You can read about it in this discussion, subscribe to it for further updates.

Oh, such a shame they stopped support :(

Thanks

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from ff1acc2 to aa0f12a Compare June 24, 2022 21:48
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from a2256b4 to 51d2505 Compare December 5, 2022 03:37
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 4 times, most recently from 72a940d to db2963c Compare December 12, 2022 19:57
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from db2963c to fa55f9e Compare December 16, 2022 23:56
@renovate renovate bot changed the title fix(deps): update dependency node-fetch to v3 Update dependency node-fetch to v3 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from b213928 to 7f941cc Compare January 10, 2023 18:46
@nickfloyd nickfloyd added the esm-blocked Temporary label to denote esm dependency blocker label Jan 11, 2023
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 7f941cc to c758f9a Compare January 14, 2023 19:53
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from c758f9a to d4ea3ad Compare January 21, 2023 20:49
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from d4ea3ad to 6b6c32b Compare February 9, 2023 17:05
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 6b6c32b to c22c7f3 Compare February 27, 2023 19:09
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from 56ac81f to 18a440e Compare March 24, 2023 14:59
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 18a440e to 2cea78e Compare March 24, 2023 17:26
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 2cea78e to 1aa2f85 Compare April 3, 2023 20:43
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from 1aa2f85 to ff7ae38 Compare April 23, 2023 23:52
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 2 times, most recently from 89df558 to aa3a0bf Compare May 18, 2023 13:28
@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339 wolfy1339 mentioned this pull request May 21, 2023
@styfle
Copy link
Contributor

styfle commented May 22, 2023

This can be closed now that #580 landed

@wolfy1339
Copy link
Member

Let's keep it open until it lands in the final stable version

@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch 3 times, most recently from 71fa0d3 to f5ad233 Compare June 14, 2023 23:53
@renovate renovate bot force-pushed the renovate/node-fetch-3.x branch from f5ad233 to b7564b6 Compare June 16, 2023 16:59
@renovate renovate bot deleted the renovate/node-fetch-3.x branch June 16, 2023 21:09
@github-actions
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm-blocked Temporary label to denote esm dependency blocker released on @beta released Status: Blocked Some technical or requirement is blocking the issue Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants