-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Kiota generated Java SDK #50
base: main
Are you sure you want to change the base?
Conversation
cc. @baywet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together! A couple of comments.
- name: Install kiota | ||
run: dotnet tool install --global Microsoft.OpenApi.Kiota --prerelease | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Install kiota | |
run: dotnet tool install --global Microsoft.OpenApi.Kiota --prerelease |
- uses: actions/setup-dotnet@v4 | ||
with: | ||
dotnet-version: '8.x.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- uses: actions/setup-dotnet@v4 | |
with: | |
dotnet-version: '8.x.x' | |
- uses: microsoft/setup-kiota@v0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to go in the direction you are proposing, but, currently, the installation of the tools is based on dotnet tool install
, if we move to the specific GH Action it would be best to update all of the jobs.
Looking for the maintainers of this project guidance here.
-d schemas/downloaded.json \ | ||
--serializer none \ | ||
--deserializer none \ | ||
--exclude-path "/repos/{template_owner}/{template_repo}/generate" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc. @baywet this seems to be a viable workaround for microsoft/kiota#4151 I think we should apply it to the Go generation script as it's affected too.
Hi @kfcampbell and @nickfloyd 👋 ,
after the work we have done in Kiota on Java it would be great to start distributing a Java SDK 😄
Here I started to spearhead the effort, but it will require some help on your side to be finalized, e.g. creating the
java-sdk
repository.The generated code can be compiled using Maven with a minimal
pom.xml
like:Happy to answer any questions and assist in the process!