Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): make OctokitResponse an interface #594

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER

Required for octokit/plugin-throttling.js#642

Before the change?

  • Plugins could not define additional properties on the response object

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Nov 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same for most types in https://github.com/octokit/octokit-next.js 👍🏼

@wolfy1339 wolfy1339 merged commit 7269dcc into main Nov 7, 2023
5 checks passed
@wolfy1339 wolfy1339 deleted the type-to-interface branch November 7, 2023 17:46
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 12.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants