Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(responses): Add ability to return eventual response body from hooks #100

Closed
wants to merge 5 commits into from
Closed

feat(responses): Add ability to return eventual response body from hooks #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac4a20b
Send optional response body
MLBMatt Nov 4, 2019
21bd6a9
Remove idea
MLBMatt Nov 4, 2019
9c93334
Add merged response bodies from hooks
MLBMatt Nov 5, 2019
0e956c8
Add undefined case
MLBMatt Nov 5, 2019
6fa376b
Revert package.json change
MLBMatt Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.nyc_output
coverage
node_modules
.idea
10 changes: 8 additions & 2 deletions event-handler/receive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,15 @@ function receiverHandle (state, event) {
.catch(error => errors.push(Object.assign(error, { event })))
})

return Promise.all(promises).then(() => {
return Promise.all(promises).then((results) => {
const mergedResults = results.reduce((merged, curr) => {
if (typeof curr === 'object') {
return Object.assign({}, merged, curr)
} else { return merged }
}, {})

if (errors.length === 0) {
return
return mergedResults
}

errorHandlers.forEach(handler => errors.forEach(wrapErrorHandler.bind(null, handler)))
Expand Down
Loading