Use DateTimeOffset everywhere instead of string (#525)

octokit · Jul 31, 2024 · 39b7372 · 39b7372
1 parent 5d268df
commit 39b7372
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJob.cs b/src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJob.cs
@@ -60,7 +60,8 @@ public sealed record WorkflowJob
     public string? RunnerGroupName { get; init; }
 
     [JsonPropertyName("started_at")]
-    public string StartedAt { get; init; } = null!;
+    [JsonConverter(typeof(DateTimeOffsetConverter))]
+    public DateTimeOffset StartedAt { get; init; }
 
     [JsonPropertyName("completed_at")]
     public string? CompletedAt { get; init; }
@@ -72,5 +73,6 @@ public sealed record WorkflowJob
     public string? HeadBranch { get; init; }
 
     [JsonPropertyName("created_at")]
-    public string CreatedAt { get; init; } = null!;
+    [JsonConverter(typeof(DateTimeOffsetConverter))]
+    public DateTimeOffset CreatedAt { get; init; }
 }
diff --git a/src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJobStep.cs b/src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJobStep.cs
@@ -18,7 +18,8 @@ public sealed record WorkflowJobStep
     public long Number { get; init; }
 
     [JsonPropertyName("started_at")]
-    public string StartedAt { get; init; } = null!;
+    [JsonConverter(typeof(DateTimeOffsetConverter))]
+    public DateTimeOffset StartedAt { get; init; }
 
     [JsonPropertyName("completed_at")]
     [JsonConverter(typeof(NullableDateTimeOffsetConverter))]