Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the merge_group event #77

Closed
JamieMagee opened this issue Jun 27, 2022 · 3 comments · Fixed by #104
Closed

Support the merge_group event #77

JamieMagee opened this issue Jun 27, 2022 · 3 comments · Fixed by #104
Labels
Good first issue Good for newcomers Type: Feature New feature or request

Comments

@JamieMagee
Copy link
Contributor

Describe the feature

Users started to receive payloads for this event (See #76). However, the details of this event are not yet in the public documentation1. We should add the full event model once the public documentation is available.

Footnotes

  1. https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads

@mntlty
Copy link

mntlty commented Jul 22, 2022

@JamieMagee when creating the webhook I also created the open api specification for it. I believe this isn't public due to published: false here https://github.com/github/github/blob/master/app/api/description/webhooks/merge-group/checks-requested.yaml#L69 but I'm not familiar with how changes to the public docs are made. Can you provide guidance on what is necessary for that to go live?

fyi @willsmythe

@JamieMagee
Copy link
Contributor Author

Unfortunately, I'm not familiar either. I just consume the API 😅

Maybe @nickfloyd knows?

@wolfy1339
Copy link
Member

The event docs are now public, and I have created schemas over in octokit/webhooks#681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants