Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add merge_group app event #76

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

martincostello
Copy link
Contributor

Add the merge_group value for app events.

I just spotted this problem in an app of mine, where handling check_suite events was failing due to merge_group being sent in the webhook payload.

      "events": [
        "branch_protection_rule",
        "check_run",
        "check_suite",
        "create",
        "delete",
        "deployment",
        "deployment_status",
        "discussion",
        "discussion_comment",
        "fork",
        "gollum",
        "issues",
        "issue_comment",
        "label",
        "merge_group",
        "milestone",
        "page_build",
        "project",
        "project_card",
        "project_column",
        "public",
        "pull_request",
        "pull_request_review",
        "pull_request_review_comment",
        "push",
        "registry_package",
        "release",
        "repository",
        "repository_dispatch",
        "status",
        "watch",
        "workflow_dispatch",
        "workflow_run"
      ]
2022-06-25 09:05:17.236 +00:00 [Error] Octokit.Webhooks.WebhookEventProcessor: Exception processing GitHub event.System.Text.Json.JsonException: The JSON value 'merge_group' could not be converted to Octokit.Webhooks.Models.AppEvent. Path: $.check_suite.app.events[14] | LineNumber: 0 | BytePositionInLine: 2251

Add the `merge_group` value for app events.
Copy link
Contributor

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It doesn't appear like there is public documentation for this event yet. I'll merge this and create a followup issue to add the full event payload once it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants