Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add installation object to pull_request_review and pull_request_review_comment events #177

Merged
merged 3 commits into from
Sep 30, 2020
Merged

fix: add installation object to pull_request_review and pull_request_review_comment events #177

merged 3 commits into from
Sep 30, 2020

Conversation

roopakv
Copy link
Contributor

@roopakv roopakv commented Sep 29, 2020

The pull request review payloa has an installation object as defined here: https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#pull_request_review

Adding this will end up fixing the typescript definitions

index.json Outdated Show resolved Hide resolved
@roopakv
Copy link
Contributor Author

roopakv commented Sep 29, 2020

@gr2m updated please take a look when you get a chance :)

@gr2m gr2m changed the title fix: add installation object to pull_request_review fix: add installation object to pull_request_review and pull_request_review_comment events Sep 30, 2020
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@gr2m gr2m added the Type: Bug Something isn't working as documented label Sep 30, 2020
@gr2m gr2m merged commit 519505f into octokit:master Sep 30, 2020
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.13.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants