Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always have examples with requested_reviewers #183

Conversation

christophehurpeau
Copy link
Contributor

Related to octokit/webhooks.js#293

This ensure all "requested_reviewers" array are typed

It however doesn't make sense that the creator is the same as the requested_reviewer, is there another example user I could use ?

@christophehurpeau
Copy link
Contributor Author

Oups, I'll fix the conflicts

@gr2m
Copy link
Contributor

gr2m commented Oct 5, 2020

It however doesn't make sense that the creator is the same as the requested_reviewer, is there another example user I could use ?

Maybe https://api.github.com/users/octocat?

@christophehurpeau christophehurpeau force-pushed the feat/always-have-examples-with-requested_reviewers branch from 0808be9 to 8fc4d40 Compare October 5, 2020 20:14
@christophehurpeau
Copy link
Contributor Author

@gr2m yes thanks ! updated with that user :)

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@gr2m gr2m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Oct 5, 2020
@gr2m gr2m merged commit b3fdcc8 into octokit:master Oct 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants