Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate test jobs #896

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 18, 2024


Before the change?

  • @github-actions Test / test (pull_request) Failing after 1m
  • @github-actions Test / test (pull_request) Successful in 15s
image

After the change?

  • The two jobs have distinct names

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

This will require intervention from the Org admins due to the name change, since the branch protection rules will need updating.
@nickfloyd @gr2m @kfcampbell

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 18, 2024
@nickfloyd nickfloyd merged commit 9220fee into octokit:main Feb 20, 2024
9 checks passed
@nickfloyd
Copy link
Contributor

The rules have been reflected to require the status checks CI Checks and Type Check on main to be passing. We'll probably need to go back through on existing PRs and push an empty commit to trigger those rules.

@jsoref jsoref deleted the disambiguate-test-jobs branch February 20, 2024 19:12
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants