Skip to content

Commit

Permalink
MRG: Merge pull request #11 from octue/remove-order-attributes
Browse files Browse the repository at this point in the history
Stop extracting outdated `order` parameter from events in event handler
  • Loading branch information
cortadocodes authored Jul 15, 2024
2 parents b2aaf2c + 8a78ca8 commit 49e7a7c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 0 additions & 1 deletion functions/event_handler/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def store_pub_sub_event_in_bigquery(cloud_event):
"question_uuid": attributes.pop("question_uuid"),
"parent_question_uuid": attributes.pop("parent_question_uuid"),
"originator_question_uuid": attributes.pop("originator_question_uuid"),
"order": attributes.pop("order"),
# Backend-specific metadata.
"backend": BACKEND,
"backend_metadata": backend_metadata,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

setup(
name="twined-gcp",
version="0.6.0",
version="0.6.1",
author="Marcus Lugg <marcus@octue.com>",
install_requires=[
"setuptools",
Expand Down
2 changes: 0 additions & 2 deletions tests/test_event_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def test_store_pub_sub_event_in_bigquery(self):
"question_uuid": "ca534cdd-24cb-4ed2-af57-e36757192acb",
"parent_question_uuid": "1d897229-155d-498d-b6ae-21960fab3754",
"originator_question_uuid": "fb6cf9a3-84fb-45ce-a4da-0d2257bec319",
"order": "0",
"forward_logs": True,
},
"messageId": "1234",
Expand Down Expand Up @@ -61,7 +60,6 @@ def test_store_pub_sub_event_in_bigquery(self):
"question_uuid": "ca534cdd-24cb-4ed2-af57-e36757192acb",
"parent_question_uuid": "1d897229-155d-498d-b6ae-21960fab3754",
"originator_question_uuid": "fb6cf9a3-84fb-45ce-a4da-0d2257bec319",
"order": "0",
"backend": "GoogleCloudPubSub",
"backend_metadata": {"message_id": "1234", "ordering_key": None},
},
Expand Down

0 comments on commit 49e7a7c

Please sign in to comment.