Fix warnings and CI failure #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File "lib/db_store.ml", line 9, characters 4-27:
9 | cancelled : unit Lwt.t;
^^^^^^^^^^^^^^^^^^^^^^^
Error (warning 69 [unused-field]): record field cancelled is never read.
(However, this field is used to build or mutate values.)
talex5
reviewed
Jul 8, 2022
ocaml-ci executes this if only obuilder-spec can be build:
opam exec -- dune build --only-packages=obuilder-spec @install @check @runtest && rm -rf _build
Dune would try to build stress.exe as part of the obuider-spec package
@check alias. However, stress links with the obuilder library and such
is part of the obuilder package. The easiest way to express it is to
make it a no-op test of the obuilder package, so that it is not build
with obuilder-spec.
|
Applied your suggestions, thanks. |
|
Thanks! |
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Nov 7, 2022
CHANGES: - Add --fuse-path to allow selection of the path redirected by FUSE (@mtelvers ocurrent/obuilder#128, reviewed by @MisterDA ) - Pre-requisites for Windows support using docker for Windows (@MisterDA ocurrent/obuilder#116, reviewed by @tmcgilchrist) - Additional tests and prerequistes for Windows support (@MisterDA ocurrent/obuilder#130, reviewed by @tmcgilchrist) - Add support for Docker/Windows spec (@MisterDA ocurrent/obuilder#117, reviewed by @tmcgilchrist) - Depend on Lwt.5.6.1 for bugfixes (@MisterDA ocurrent/obuilder#108, reviewed by @tmcgilchrist) - Add macOS support (@patricoferris ocurrent/obuilder#87, reviewed by @tmcgilchrist @talex5 @kit-ty-kate) - Enable macOS tests only on macOS (@MisterDA ocurrent/obuilder#126, reviewed by @tmcgilchrist) - Dune 3.0 generates empty intf for executables (@MisterDA ocurrent/obuilder#111, reviewed by @talex5) - Fix warnings and CI failure (@MisterDA ocurrent/obuilder#110, reviewed by @talex5) - Expose store root and cmdliner term with non-required store (@MisterDA ocurrent/obuilder#119, reviewed by @tmcgilchrist) - Expose Rsync_store module (@MisterDA ocurrent/obuilder#114, reviewed by @talex5) - Rsync hard-links to save space (@art-w ocurrent/obuilder#102, reviewed by @patricoferris)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to Dune 3.3 enables warnings 67 (unused functor parameter) and 69 (record field is never read), which I tried fixing.
If only the
obuilder-specpackage is build, then Dune tries to build thestress.exeexecutable which requires theobuidlerlibrary. Use a workaround to attachstress.exeto theobuilderpackage.