Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export (extended table, RDF-turtle, json-ld) does not work #231

Closed
tomas-knap opened this issue Nov 30, 2016 · 3 comments
Closed

Export (extended table, RDF-turtle, json-ld) does not work #231

tomas-knap opened this issue Nov 30, 2016 · 3 comments
Assignees
@josef-janousek
Labels
bug extension java priority: High
Milestone
4th iteration

Comments

@tomas-knap
Copy link
Member

tomas-knap commented Nov 30, 2016 •
edited by brodecva
Loading

To reproduce, use file: https://github.com/odalic/sti/files/622142/STMK_2012_LIVEBIRTHS-10lines.csv.zip

See also: #175

Possible cause: Not all cell values disambiguated/classified. But it should be robust enough to work correctly

It must at least report some reasonable issue - why it is not able to generate export!

TODO: Define how does it behave in case class/disamb is not complete
@tomas-knap tomas-knap added the bug label Nov 30, 2016
@tomas-knap tomas-knap added this to the 4th iteration milestone Nov 30, 2016
@tomas-knap tomas-knap changed the title Export (extended table, RDF-turtle) does not work Export (extended table, RDF-turtle, json-ld) does not work Nov 30, 2016
@brodecva brodecva assigned josef-janousek and unassigned brodecva Dec 1, 2016
josef-janousek added a commit that referenced this issue Dec 7, 2016
@josef-janousek
#231 - export corrections (skip empty values)
98193ae
@josef-janousek
Copy link
Member

Now it should be corrected.
When the value of classification/disambiguation is empty, then no triple is produced.

@brodecva brodecva assigned brodecva and unassigned josef-janousek Dec 8, 2016
@brodecva
Copy link
Member

brodecva commented Dec 8, 2016

An error found and a solution discussed with @josef-janousek , that appears on the reduced DBpedia dataset used.

@brodecva brodecva removed the in test label Dec 8, 2016
@brodecva brodecva assigned josef-janousek and unassigned brodecva Dec 8, 2016
josef-janousek added a commit that referenced this issue Dec 8, 2016
@josef-janousek
#231 - export corrections (no empty strings in csv export)
f9703ec
brodecva added a commit that referenced this issue Dec 9, 2016
@brodecva
Merge pull request #234 from odalic/231_ExportCorrections
2e2e531 
#231 - export corrections (skip empty values)
@brodecva brodecva closed this as completed Dec 9, 2016
@brodecva
Copy link
Member

brodecva commented Dec 9, 2016

The fix seems to work, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josef-janousek josef-janousek

Labels
bug extension java priority: High
Projects
None yet
Milestone
4th iteration
Development

No branches or pull requests
3 participants
@tomas-knap @brodecva @josef-janousek