Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Limitations to match current spec #177

Merged
merged 9 commits into from
May 14, 2024
Merged

Update Limitations to match current spec #177

merged 9 commits into from
May 14, 2024

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented May 9, 2024

Description

  1. Updates the Limitations section in README against the spec as of March. https://www.w3.org/TR/css-anchor-position-1
  2. Adds Status note to Demo, and deprecation notice on @position-fallback example.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit edd5b5c
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/6643cfaf6635a500082b11f2
😎 Deploy Preview https://deploy-preview-177--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit edd5b5c
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/6643cfafcd621c00084a13be

@jamesnw
Copy link
Contributor Author

jamesnw commented May 9, 2024

There were also some additions to the spec that may impact the polyfill logic in some way.

  1. New section on "anchor relevance".
  2. In creating an anchor, new specification that Pseudo elements have same implicit anchor as originating element unless otherwise specified.
  3. New requirements for acceptable anchor points:
    1. el is either an element, or a [pseudo-element (https://www.w3.org/TR/selectors-4/#pseudo-element) that acts like one.
    2. el is not in the skipped contents of another element.
  4. Anchor function validity- adds new requirement that there be a target element.

I also chose to mirror what the Container Query polyfill did, and specify that we will not polyfill the JS APIs.

@jamesnw jamesnw requested a review from jgerigmeyer May 9, 2024 19:28
@jamesnw jamesnw requested a review from SondraE May 14, 2024 16:11
Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesnw Let's link people to the GH sponsor page instead of the Open Collective page. We are planning to add a specific goal for Anchor Positioning funding on the GH sponsor page. Seems like it may be a good idea to add that goal to this spec demo whenever we have that on GH.
https://github.com/sponsors/oddbird

@jamesnw jamesnw merged commit ca104d3 into main May 14, 2024
10 checks passed
@jamesnw jamesnw deleted the spec-changes branch May 14, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants