-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position anchor #196
Position anchor #196
Conversation
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesnw I'm slowly trying to re-learn this codebase, so forgive me if my concern here is completely off! 😅
@jgerigmeyer This is ready for re-review at your convenience. I did opt to leave out support |
This does introduce a new regression in anchor-position-multicol-colspan-001.html, This change passes 12 new subtests, mostly in areas where |
* main: chore(deps-dev): Bump the dev group across 1 directory with 11 updates chore(deps): Bump @types/css-tree from 2.3.7 to 2.3.8 in the prod group no more eslint updates chore(deps-dev): Bump ws from 8.17.0 to 8.17.1 in the npm_and_yarn group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! A few remaining questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@jamesnw I'm happy for you to merge this if you don't have more changes! |
Description
Implements the
position-anchor
property.Related Issue(s)
#179
Steps to test/reproduce
View the demo in a browser that needs the polyfill, and apply the polyfill.
Show me
.class#id
as.class #id
is not an internal bugauto
value (defer until later)