-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add anchor-scope
support
#217
Conversation
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmalerba This is great -- thanks! 🚀 A few tasks before it's ready to merge:
- There are some tests in
validate.test.ts
that are using the outdated call signature forvalidatedForPositioning
andisAcceptableAnchorElement
. - We merged in Pseudo-element anchors #213 this morning, and there are a few merge conflicts -- could you rebase off of
main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think you could remove anchor-scope
from the "Limitations" list in the README, or add a clarification that it's not supported for pseudo-elements.
No description provided.