Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pseudo-element anchors with overflow: scroll; parents #221

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ayoreis
Copy link
Contributor

@ayoreis ayoreis commented Jul 23, 2024

I started to write the issue but then it felt simpler to fix it :)

The only thing I'm not sure about is the demo, I changed it for this case but now there isn't one without scrolling, having both maybe gets too long?

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit 373f0d3
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/669fddc49b952a000850e2d1

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit 373f0d3
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/669fddc4690b2c0008d43259
😎 Deploy Preview https://deploy-preview-221--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm not sure about is the demo, I changed it for this case but now there isn't one without scrolling, having both maybe gets too long?

I'm fine with this as-is 👍

@jgerigmeyer jgerigmeyer merged commit 855cf7a into oddbird:main Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants