Respect CSS cascade when determining anchor-name
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
mmalerba
force-pushed
the
anchor-name-cascade
branch
from
0550ab2
to
9fc927b
Compare
jgerigmeyer
requested changes
Jul 25, 2024
There was a problem hiding this comment.
This is great, and goes a long way toward #216 as well. A few typos and minor comments, but nothing concerning functionality. 👏
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
mmalerba
force-pushed
the
anchor-name-cascade
branch
from
d22e94e
to
048dfd4
Compare
jgerigmeyer
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218, #212