Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallbacks: flip anchor functions that are nested in other function calls #244

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

tuespetre
Copy link
Contributor

Not aware of an existing open issue for this, but I encountered it today.

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit ede0a6e
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/66e4558a468e0800081f906d

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit ede0a6e
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/66e4558a9541520008f6b439
😎 Deploy Preview https://deploy-preview-244--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/fallback.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the Limitations section in the README.md to reflect this improvement?

Thanks for doing this!

src/fallback.ts Outdated Show resolved Hide resolved
@jgerigmeyer jgerigmeyer merged commit 3ca0e2c into oddbird:main Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants