Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not revoke object URL of polyfilled styles #260

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

jgerigmeyer
Copy link
Member

Description

After loading the polyfilled styles, we were calling revokeObjectURL to release the URL. If the polyfill is applied again, this caused an error when trying to fetch the already-polyfilled styles from the blob URL.

Related Issue(s)

#253

Steps to test/reproduce

  • Open in Firefox
  • Click the "Polyfill these elements" manual button
  • Click the global "Apply Polyfill" button
  • No error is thrown

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit 80d21ef
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/670d62b0d980db0008e9c462
😎 Deploy Preview https://deploy-preview-260--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit 80d21ef
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/670d62b0d980db0008e9c466

@jgerigmeyer jgerigmeyer linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only hesitation is whether we want to keep a list of the urls around so that we could clean them up later, but I can't think of a tangible benefit of doing so.

@jgerigmeyer
Copy link
Member Author

My only hesitation is whether we want to keep a list of the urls around so that we could clean them up later, but I can't think of a tangible benefit of doing so.

Yeah, I wondered about that too. It seems like knowing what to do requires more planning around the intended lifecycle of the polyfill, i.e. solving #91. I think this fix is better than the current implementation, and we can expand down the road?

@jgerigmeyer jgerigmeyer merged commit 8bacf91 into main Oct 14, 2024
14 checks passed
@jgerigmeyer jgerigmeyer deleted the hotfix-blob-urls branch October 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Stylesheet <link> URLs are swapped for blobs in v0.2.0
2 participants