Add displayed code samples #41
Conversation
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@jgerigmeyer Curious to how you see this coming along so far. I've added plain language notes for each (working) example along with relevant code. I hid the notes and code for the two examples that I think aren't working yet?
I think the intro paragraph could use another sentence or two explaining the demo? @sanajaved7 and @oluoluoxenfree if you have any feedback on the introduction/example code/and explanation notes that would be great too. |
There was a problem hiding this comment.
@dvdherron Looks good to me! I made a few minor wording edits, made one change to the positioning of the scroll example (so that the elements are visible initially without scrolling), and commented out the non-supported examples entirely (so that users aren't confused by them).
It'd be awesome if we could automatically pull the sample CSS from the actual CSS files, so we don't have to remember to keep the demos up-to-date if we change the CSS... But probably not a top priority for now. 👍
@jgerigmeyer Your changes look good and make sense. Good call on hiding the non-supported examples completely for now. And I agree it would be ideal to have the CSS update automatically. Something we can look into later. 👍🏽 |
* main: chore(deps): Automated dependency upgrades Update GH Actions output syntax
|
@sanajaved7 I prepped this for a v0.0.1 release, so once you review it I'll merge and do a new release. |
Show me
Provide screenshots/animated gifs/videos if necessary.