Set positions via CSS custom properties instead of directly on target elements. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgerigmeyer
requested review from
mirisuzanne,
oluoluoxenfree and
sanajaved7
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jgerigmeyer
requested review from
jerivas
and removed request for
oluoluoxenfree
|
@mirisuzanne @jerivas Since Sana and Olu are out, would the two of you be willing to review this PR sometime? Not urgent, of course. |
jerivas
approved these changes
Nov 18, 2022
❌ Deploy Preview for anchor-position-wpt failed.
|
mirisuzanne
approved these changes
Nov 21, 2022
Yep! That's coming in the next PR... #52 |
* main: do not warn on TS version chore(deps): Automated dependency upgrades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, we were calculating positions and then setting them directly via
targetElement.style.setProperty(...). This isn't ideal for two reasons:anchor()call from the stylesheet is overridden by a different set of styles?anchorfunction, e.g.top: calc(anchor(--my-anchor 100%) - 50px);.With the changes in this PR, we are now replacing uses of
anchor()with a unique generated CSS custom property directly in the stylesheet, and then after we calculate the position value we simply assign that pixel value to the relevant CSS custom property. This way we can allow CSS itself to handle the cascade, and any relevant math.Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
View the demo and confirm that the examples still work (including the new "used in math function" example).