Sticky header #59
Sticky header #59
Conversation
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
* main: (48 commits) try new approach for testing dumb browsers and their dumb subpixel rounding adjust regex for tests adjust regex for tests Use rounded values for e2e tests chore(deps): Automated dependency upgrades empty commit to trigger deploy preview lint Support implicit anchors via anchor attribute. Back to official WPT repo Exclude irrelevant WPTs tests Bump actions/setup-python from 3 to 4 chore(deps): Automated dependency upgrades Fix custom props passed through other custom props. fix tests Do not overwrite DOM platform fns chore(deps): Automated dependency upgrades Test against our own WPT branch Set passing tests to 0 for unknown results lint ...
@oluoluoxenfree @dvdherron I think there's plenty of horizontal space, it would make sense to me if we place the button on the far right and only wrap below on narrow screens. |
|
@oluoluoxenfree How close are we to wrapping up this PR? |
|
@jgerigmeyer I can make the z-index change now but the grid change I'm not sure about; if it's fine to have it below for now I can fix it in another PR |
|
@oluoluoxenfree Looks good. It's not urgent, but @dvdherron could you provide some suggestions for moving the button to the right side? |
* main: Use env vars to disable WPT result builds
Missed this before I signed off yesterday. My first instinct would be to do a named grid-template with the
I can sketch up something really quick if that helps @oluoluoxenfree |
|
that would help, thanks so much @dvdherron |
|
The buttton sits on the opposite side of the header now:
We could also but everything in one row if that space in the middle looks too big on wide screens:
|
|
I think this is ready for a review @stacyk @jgerigmeyer @oluoluoxenfree |
Header now sticky and button moved to the top; not sure if it should further to the right?
Show me
REMEMBER: Attach this PR to the Trello card