Handling fixed position and refactoring validation #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ui platform methods
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sanajaved7
requested review from
jgerigmeyer
and removed request for
jgerigmeyer
jgerigmeyer
reviewed
Dec 15, 2022
jgerigmeyer
reviewed
Dec 15, 2022
jgerigmeyer
reviewed
Dec 15, 2022
* main: Use env vars to disable WPT result builds
Updating comments Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Updating function that's no longer async Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
* main: Fix automatic WPT comment Run WPTs against browserslist clean up header styles wip header grid Update comment Specify the target repo Single quotes? Use the PR opened event Missing token Add link to WPT report move z index linting applied suggestions: stack button and nav, remove button from nav, add z-index linting remove change to tests header sticky and button moved to top
* main: chore(deps): Automated dependency upgrades
jgerigmeyer
reviewed
Dec 21, 2022
There was a problem hiding this comment.
@sanajaved7 Nice work! Do you think it's worth adding a fixed-position demo, or can we point to a WPT test to demonstrate that this works? I was hoping this would fix the failing anchor-position-003.html test, but it doesn't seem to. 😕
Using isFixedPosition method Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
jgerigmeyer
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
windowobject is returned in certain paths so we updated our logic, specifically when looking for the initial containing block and going up the containing block chain to account for this)