Use env vars to disable WPT result builds #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-position-wpt canceled.
|
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jgerigmeyer
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
ignoreconfig to skip builds that don't end with--wpt-results. Since this repo is the source of both https://anchor-polyfill.netlify.app/ and https://anchor-position-wpt.netlify.app/, I also added support for aWPT_ONLYenv var to disable the branch name matching. In the Netlify UI the variable exists only for the WPT site, so the main site continues building for all branches.Steps to test/reproduce
I think we'll need to merge into
mainso Netlify picks upnetlify.toml, because this branch is still being built by the WPT site and failing 🤷♂️EDIT: Actually, it looks like it's working. The main site logs say the command allowed the build, and the WPT site logs say the build was canceled. The Netlify GH bot also seems to reflect that in the automated comments. More importantly, the GH checks are passing 👍