Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow updating anchor on every animationFrame. #87

Merged
merged 9 commits into from
Mar 9, 2023
Merged

Allow updating anchor on every animationFrame. #87

merged 9 commits into from
Mar 9, 2023

Conversation

jgerigmeyer
Copy link
Member

@jgerigmeyer jgerigmeyer commented Mar 2, 2023 •
edited
Loading

Fixes #73.

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit 6c62eba
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/64060c1f773895000834053a
😎 Deploy Preview https://deploy-preview-87--anchor-polyfill.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit 6c62eba
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/64060c1f9b733a0008cfbe26

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

WPT report for this branch: https://animation-frame-api-wpt-results--anchor-position-wpt.netlify.app

@jgerigmeyer jgerigmeyer marked this pull request as ready for review March 3, 2023 19:50
@jgerigmeyer jgerigmeyer requested a review from jerivas March 3, 2023 19:51
@jgerigmeyer
Copy link
Member Author

@sanajaved7 @jerivas This exposes an opt-in API for updating on animationFrame, in addition to the usual resize/scroll. This seems to fix at least most examples in #73 (e.g. drag-and-drop).

@jgerigmeyer jgerigmeyer mentioned this pull request Mar 3, 2023
Closed
@jgerigmeyer
Merge branch 'main' into animation-frame-api
7a9c862 
* main:
  chore(deps): Automated dependency upgrades
@jgerigmeyer
update spec link
6c62eba
jerivas
jerivas approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@jerivas jerivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% familiar with what's going on, but from what I can gather it all makes sense

sanajaved7
sanajaved7 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@sanajaved7 sanajaved7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨

@jgerigmeyer jgerigmeyer merged commit 6222c88 into main Mar 9, 2023
@jgerigmeyer jgerigmeyer deleted the animation-frame-api branch March 9, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerivas jerivas jerivas approved these changes

@sanajaved7 sanajaved7 sanajaved7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update when anchor moves
3 participants
@jgerigmeyer @jerivas @sanajaved7