Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
  • Loading branch information
mirisuzanne and jgerigmeyer authored Oct 1, 2024
1 parent 63e57b8 commit 5c54c9d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions content/blog/2024/grid-masonry-nuance.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ divided somewhat evenly across our tracks --
aligned on one axis,
but packing more densely on the other.

At it's core,
At its core,
a 'masonry' layout
works like 'grid' layout on one axis
and 'flexbox' on the other.
Expand Down Expand Up @@ -160,7 +160,7 @@ works by first placing 'hypothetical' items
_in every position that the item could potentially occupy_ --
and then proceeding with normal grid track sizing,
before finally placing the actual items
in their actual position.
in their actual positions.

There may still be more to work out here,
but the goal seems to be
Expand Down Expand Up @@ -446,7 +446,7 @@ that would mean duplicating the track definitions:
}
```

We could put those track definition inside a variable if we want,
We could put those track definitions inside a variable if we want,
but it still requires explicit duplication.

Because we can rely on various properties working
Expand Down

0 comments on commit 5c54c9d

Please sign in to comment.