-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Anchor position update #645
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..anchor-update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few things that you could consider updating.
-
In the blurb, I found myself unsure what "support" referred to. Browser support? Financial support? So here are ideas for clarifying that just a bit.
"Sponsor support for continued development of the Anchor Position Spec is making the Anchor Position Polyfill more useful. Here's a summary of the latest updates."
OR
"Donations from sponsors for continued development of the Anchor Position Spec is making the Anchor Position Polyfill more useful. Here's what's new!" -
"some of the upcoming ones are-" I would change that to "some of the upcoming ones are:" (Use a colon instead of a dash.)
-
At most screen sizes that I have available to view the header image, I can't see the bottom of the anchor. I see the chains, mostly. Could you re-position the image so that the really recognizable part of the anchor is in view on more screen sizes?
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Description
Anchor Position update
https://deploy-preview-645--oddleventy.netlify.app/2024/06/26/anchor-position-polyfill/