v0.3.3

oddbird · Nov 28, 2023 · 03153a2 · 03153a2
1 parent c32962e
commit 03153a2
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Popover Attribute Polyfill Changelog
 
+## 0.3.3: 2023-11-28
+
+- 🐛 BUGFIX: Check slotted content for autofocus delegate --
+  [#150](https://github.com/oddbird/popover-polyfill/pull/150)
+- 🏠 INTERNAL: Upgrade dependencies
+
 ## 0.3.2: 2023-11-13
 
 - 🚀 NEW: Update TypeScript definitions to be compatible with v5 --

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oddbird/popover-polyfill",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Popover Attribute Polyfill",
   "license": "BSD-3-Clause",
   "publishConfig": {

diff --git a/src/popover-helpers.ts b/src/popover-helpers.ts
@@ -184,7 +184,10 @@ function isFocusable(focusTarget: HTMLElement) {
   return focusTarget.tabIndex !== -1;
 }
 
-// https://html.spec.whatwg.org/#focus-delegate
+// This method is not spec compliant, as it also looks in slotted content
+// for autofocus elements.
+// See: https://github.com/oddbird/popover-polyfill/issues/149
+// Spec: https://html.spec.whatwg.org/#focus-delegate
 function focusDelegate(focusTarget: HTMLElement) {
   if (
     focusTarget.shadowRoot &&
@@ -221,7 +224,7 @@ function focusDelegate(focusTarget: HTMLElement) {
   );
   let descendant: Node | null = walker.currentNode;
   while (descendant) {
-    // TODO: this is not spec compliant
+    // this is not spec compliant
     if (isFocusable(descendant as HTMLElement)) {
       return descendant;
     }