fix: querySelector APIs support null/undefined (closes #104) #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To demonstrate this, you can see this in action if you go to the demo in a browser that doesn't natively implement popover, and in the console execute:
This causes some interop issues with other 3rd party libraries.
Expected behavior
document.querySelector
does not throw an error, and returns null.Actual behavior
Error thrown: Uncaught TypeError: can't access property "includes", selector is null
Firefox: