Assign adoptedStyleSheets rather than push #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some older browsers such as Chrome 99 have `adoptedStyleSheets` but it is a frozen array, rather than an `ObservableArray`, and can only be assigned to rather than `push()`ed to. Pushing to a frozen array causes an error to be thrown and so the polyfill doesn't work in those browsers if we continue to use push. The fix for this is to always use an assignment on the array, it's a little slower the impact will be negligible. See https://chromestatus.com/feature/5638996492288000 for some more detail.
✅ Deploy Preview for popover-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@jgerigmeyer just a friendly ping, would be great to get this one merged! |
jgerigmeyer
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks good! @keithamus I'm traveling and won't be able to cut a new release until tomorrow.
|
Thanks for the review and merge @jgerigmeyer. Happy travels! |
|
@keithamus Published in v0.3.1 🚀 |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some older browsers such as Chrome 98 have
adoptedStyleSheetsbut it is a frozen array, rather than anObservableArray, and can only be assigned to rather thanpush()ed to. Pushing to a frozen array causes an error to be thrown and so the polyfill doesn't work in those browsers if we continue to use push.The fix for this is to always use an assignment on the array, it's a little slower the impact will be negligible.
See https://chromestatus.com/feature/5638996492288000 for some more detail.
Steps to test/reproduce
TypeError: Cannot add property 0, object is not extensible.Show me