Check slotted content for autofocus delegate

[jpzwarte]

Fixes #149

[netlify]

✅ Deploy Preview for popover-polyfill ready!

Name	Link
🔨 Latest commit	dda43c0
🔍 Latest deploy log	https://app.netlify.com/sites/popover-polyfill/deploys/6560926319eb98000811e46e
😎 Deploy Preview	https://deploy-preview-150--popover-polyfill.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jgerigmeyer]

Thanks for the contribution! Looks fine to me -- @keithamus what do you think?

[keithamus]

The change LGTM. A minor nit is that the focusDelegate function comes directly from the spec, but it has now diverged from the spec text quite significantly. We should probably add some commentary that this is no longer spec compliant (even though the current function is desirable). Perhaps a follow up can be made here?

[jpzwarte]

The change LGTM. A minor nit is that the focusDelegate function comes directly from the spec, but it has now diverged from the spec text quite significantly. We should probably add some commentary that this is no longer spec compliant (even though the current function is desirable). Perhaps a follow up can be made here?

I haven't read the spec, but as far as this PR is concerned: in Chrome & Safari, a slotted [autofocus] element has the same behavior as this PR.

I assume you will merge the PR since I can't do it?

[keithamus]

I haven't read the spec, but as far as this PR is concerned: in Chrome & Safari, a slotted [autofocus] element has the same behavior as this PR.

Yes I agree, getting the behaviour right is important. The concern was around the readability of this polyfill as all methods are mapped 1-1 to the spec, as much as we can, and any deviations are called out.

I assume you will merge the PR since I can't do it?

@jgerigmeyer is probably better merging this and releasing; I do have permissions to merge but not to release.

[jgerigmeyer]

Released in v0.3.3