Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend popover stylesheet #156

Merged
merged 1 commit into from
Nov 29, 2023
Merged

prepend popover stylesheet #156

merged 1 commit into from
Nov 29, 2023

Conversation

keithamus
Copy link
Collaborator

Description

This may go some of the way to fixing #147 which is still an issue for users, despite #153 which dropped selector specificity down to 0,0,0. Right now if a selector is used that has a specificity of 0,0,0, the polyfill will still potentially override it as the popover styles get appended to the head/adoptedStyleSheets, and as such will be lower in the cascade.

This change ensures that the popover stylesheet is prepended rather than appended, which means it will appear as high up in the cascade as possible, rather than potentially at the bottom.

Steps to test/reproduce

N/A

Show me

N/A

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit 7106a79
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/6566ffa4e184720008884de8
😎 Deploy Preview https://deploy-preview-156--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgerigmeyer jgerigmeyer merged commit 5edeff3 into main Nov 29, 2023
7 checks passed
@jgerigmeyer jgerigmeyer deleted the prepend-popover-stylesheet branch November 29, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants