allow esc to be defaultpreventable #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for popover-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jgerigmeyer
approved these changes
Nov 30, 2023
|
@jgerigmeyer do you think you could release this one as a patch please? |
@keithamus Done! |
|
Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Browsers' native
popoversupport allows for theEsckeypress to be preventable, which means that the popover won't close.This is useful for capturing the
Esckey behaviour from within a popover to do other things without closing the popover.Currently the polyfill does not allow for this. This PR checks the flag to ensure default hasn't been prevented.
Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
I can follow up with steps/tests if we feel it necessary (time is short right now).
Show me
Provide screenshots/animated gifs/videos if necessary.