Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ESM Documentation #161

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Improve ESM Documentation #161

merged 2 commits into from
Dec 7, 2023

Conversation

wesbos
Copy link
Contributor

@wesbos wesbos commented Dec 7, 2023

Hello! We recently had a 500ms render blocking script load, and I think it stems back to the docs for using this being a bit confusing on how to import the polyfill. I'm clarifying how to import the polyfill with almost all JS tooling. In fact, I can't think of any tooling that doesn't support this method.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit 272ff31
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/6571fbab44fbd10009f8af1b
😎 Deploy Preview https://deploy-preview-161--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesbos Thanks for the contribution! One typo, then good to merge. 🚀

README.md Outdated Show resolved Hide resolved
@jgerigmeyer jgerigmeyer merged commit 8db6aa1 into oddbird:main Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants