Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error if window is undefined #201

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Do not error if window is undefined #201

merged 1 commit into from
Apr 26, 2024

Conversation

jgerigmeyer
Copy link
Member

Better support for SSR environments by internally checking for typeof window === 'undefined' before applying polyfill.

Addresses #192 (comment)

@jgerigmeyer jgerigmeyer requested a review from keithamus April 26, 2024 14:44
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit e839234
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/662bbde9de480e00084119cd
😎 Deploy Preview https://deploy-preview-201--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jgerigmeyer jgerigmeyer merged commit 2423d24 into main Apr 26, 2024
7 checks passed
@jgerigmeyer jgerigmeyer deleted the ssr branch April 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants