Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for slotting elements into popovers #215

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Add support for slotting elements into popovers #215

merged 1 commit into from
Jul 19, 2024

Conversation

Totati
Copy link
Contributor

@Totati Totati commented Jul 19, 2024 •
edited
Loading

Description

Adds support for slotting elements into a popover

Related Issue

#214

Steps to test/reproduce

  1. Go to https://codepen.io/Totati/pen/abgOBPP
  2. Click on "Open popover" button.
  3. Click on the red area. It's the slotted element.

Note: I could not run playwright!

@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for popover-polyfill ready!

Name Link
🔨 Latest commit cb6cce3
🔍 Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/669a0cf5e431dc0008b077d8
😎 Deploy Preview https://deploy-preview-215--popover-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jgerigmeyer
jgerigmeyer approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgerigmeyer jgerigmeyer merged commit e2d29eb into oddbird:main Jul 19, 2024
7 checks passed
@jgerigmeyer jgerigmeyer mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgerigmeyer jgerigmeyer jgerigmeyer approved these changes

@keithamus keithamus Awaiting requested review from keithamus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Totati @jgerigmeyer