Fixup css #60
Merged
Fixup css #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows for display properties, other than `block`, e.g. `flex`, `grid`.
keithamus
commented
Jan 16, 2023
| @@ -44,7 +44,6 @@ test('popover as "manual"', async ({ page }) => { | |||
|
|
|||
| test('popover as "invalid"', async ({ page }) => { | |||
| const popover = (await page.locator('#popover6')).nth(0); | |||
| await expect(popover).toBeVisible(); | |||
There was a problem hiding this comment.
This expectation has been dropped as it does not hold true in a default Chrome environment.
jgerigmeyer
approved these changes
Jan 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes up some of the CSS to align closer to Chrome's user-agent CSS. What's changed:
[popover]as Chrome does.top,leftin favour ofinset.inset-*-*properties.1emto0.25em.initial.[popover]selector so it's always applied[popover]havingdisplay: none, and[popver]:openbeingdisplay: block, we now have[popover]:not(:open)asdisplay: none. This way one can style a popover element to be something likedisplay: gridordisplay: flexand popover will not override that.[popover][anchor]styles, to avoid conflicting with anchored positioning.Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
Show me
Provide screenshots/animated gifs/videos if necessary.
REMEMBER: Attach this PR to the Trello card