Update popover.css #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgerigmeyer / @sanajaved7 I've included the |
This comment was marked as outdated.
This comment was marked as outdated.
keithamus
force-pushed
the
css-fix-native
branch
from
2e9636d to
4c10134
Compare
* main: update changelog format code style simpler condition fix(src): remove stop propagation to allow handlers
jgerigmeyer
approved these changes
Jan 19, 2023
@keithamus I just published v0.0.7 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a slight issue with native popups, which remain
display: nonebecause[popup]:not(.\:open)is always true for those popups.To fix this issue this adds(This didn't work!)[popup]:not(.\:open, :open). In other words apply this style only if the element has neither the.\:openclass nor the:openpsuedo selector.To fix this issue this wraps the
[popup]:not(.\:open)selector in a@supports not selector([popover]:open). In other words apply this style only if the element isn't a native popover.I've tested the example page in both Chrome and Firefox, and Chrome with Experimental Web Platform features enabled.
Steps to test/reproduce
Try running the demo in Chrome with Experimental Web Technology enabled.
Show me
Provide screenshots/animated gifs/videos if necessary.
REMEMBER: Attach this PR to the Trello card