-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popover): add support for popover target element #70
Conversation
@keithamus @jgerigmeyer |
should popoverTargetElement element check advance to supported popover invokers check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking close to shippable IMO. A couple of points though:
I think we're done @keithamus |
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Excellent work!
I'll leave @jgerigmeyer or @sanajaved7 to give a second review and merge, due to the size of the change. But this is 👌 in my view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor spelling suggestion, but this looks great! Thanks for the contribution. 🎉
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Published in v0.0.9 🚀 |
Closes #66
Note that this PR:
doesn't mentioned property check for
popoverToggleTargetElement
triggers.ts
file to extract payload of code from the mainpopover.ts
popover.ts
is still cumbersome and already hard to read