Add escape to dismiss #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
add-escape-to-dismiss
branch
from
3df8a24 to
5800aae
Compare
jgerigmeyer
reviewed
Mar 14, 2023
keithamus
force-pushed
the
add-escape-to-dismiss
branch
from
b1b153c to
9a44c78
Compare
keithamus
force-pushed
the
add-escape-to-dismiss
branch
from
9a44c78 to
fe8bcc0
Compare
|
@jgerigmeyer this one has been rebased and is, IMO, good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Escapekey causing all auto popovers to be dismissed.Steps to test/reproduce
Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).
Click to show Popover 3buttonShow me
Provide screenshots/animated gifs/videos if necessary.
REMEMBER: Attach this PR to the Trello card