-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when passing fractions for gutter sizes #408
Comments
I can confirm the "may only compare numbers" error as well using gulp-sass@beta I got around the issue by putting parenthesis around the fraction. |
That sounds like a bug in LibSass. We may be able to find a workaround on our end, but better to file an issue over there. |
Sure, I can do that. I'll have a look into the source to see in which context this code triggers the error. If you know that from memory please let me know, just to make the Libsass ticket as clear as possible. |
I wont be able to look into this more until later in the day. If you have time to track it down before then, go ahead. |
Documented: sass/libsass#682 LibSass doesn't yet support fractions. |
Thank you Eric. |
I'm using gulp-sass 1.3.2 and the latest version of susy. I'm still getting this error even though when you track this to the libsass ticket as well as the one linked there this should be fixed. Any ideas? This is all I have in my sass file and it's throwing the same error still.
|
Following the trail of dependencies, I'm not sure that the latest gulp-sass includes the latest libsass yet. Looks to me like node-sass is several versions behind.
The last two releases of libsass ( |
Ah, thanks for following up so quickly on this. That definitely makes sense. I REALLY want to adopt libsass already due to the incredibly slow compile times from the ruby version but it's still a little rough around the edges :\ |
Just giving everybody a heads up who might be having problems like this. I had to update libsass to Taken from here: I am unsure if updating |
I'm also suddenly having an issue with this. Everything was working fine and somewhere along the chain of dependencies there was obviously an update that's caused this to show its head. I'm using:
I haven't been able to fix it yet and have just switched from (I know this isn't an issue with susy but that's how it manifested itself and might be useful for someone searching via Google.) |
A workaround is to define the gutter width outside map, like so:
|
Wrapping fraction in parenthesis also seems to work.
|
It looks to me like |
@ericam These are my grid settings:
When having something like that:
I'm getting the Any suggestions? |
This still seems to be an issue. Here are my grid settings:
I've started using |
Yeah, they fixed the error with fractions more generally, but not fractions retrieved from a map as far as I can tell. I filed sass/libsass#1159 to track it, and released |
With the following settings:
I get:
If I change that property to a pixel value it compiles without errors.
The
columns
propertydoesn't work when using asymmetrical grids
columns: (1 1 2 3 5 8 13),`.This returns the following:
Im running
node-sass-1.2.3
The text was updated successfully, but these errors were encountered: