Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share: with-link to avoid public file indexing #674

Merged
merged 1 commit into from
Jul 2, 2016

Conversation

odeke-em
Copy link
Owner

Enables sharing to anyone with the link but the file won't be
publicly indexed as is usually with files that are published publicly.

$ drive share --with-link ComedyPunchlineDrumSound.mp3

Fixes #568.
Follows suggestions in
#650 (comment).

Enables sharing to anyone with the link but the file won't be
publicly indexed as is usually with files that are published publicly.

```shell
$ drive share --with-link ComedyPunchlineDrumSound.mp3
```

Fixes #568.
Follows suggestions in
#650 (comment).
@odeke-em
Copy link
Owner Author

/cc @thebaddie. However, I can't yet test it on my machine because of this
https://twitter.com/odeke_et/status/748422470840029184
screen shot 2016-06-30 at 12 42 29 am

@odeke-em
Copy link
Owner Author

odeke-em commented Jul 2, 2016

I've just tested it out

$ drive share --with-link ComedyPunchlineDrumSound.mp3 
Provide access for accountType(s)
    user
    anyone

For roles(s)
    reader

Addressees:
    + Anyone with the link

File(s) to share:
    + ComedyPunchlineDrumSound.mp3

Proceed with the changes? [Y/n]:y
successful share for ComedyPunchlineDrumSound.mp3 with email "", role "reader" accountType "anyone"
$ drive stat ComedyPunchlineDrumSound.mp3 

/share-testing/ComedyPunchlineDrumSound.mp3
Filename                  ComedyPunchlineDrumSound.mp3  
FileId                    0Bwu8laYc9RTPOVNSeElpdFBpS2M  
Bytes                     40656                         
Size                      39.70KB                       
DirType                   file                          
VersionNumber             907356                        
MimeType                  audio/mpeg                    
Etag                      "1TJQgR03e3kullTvmPoNa3p7rGU/MTQ2NzI3MTg2NTAwMA"
ModTime                   2016-06-30 07:31:05 +0000 UTC 
LastViewedByMe            2016-07-02 20:15:43 +0000 UTC 
Shared                    true                          
Owners                    Emmanuel Odeke                
LastModifyingUsername     Emmanuel Odeke                
Md5Checksum               9c09db6a1c7a18f7b647255c91cf4b6e
Copyable                  true                          
Starred                   false                         
Viewed                    true                          
Trashed                   false                         
ViewersCanDownload        false                         

*
Name: Emmanuel Odeke <emm.odeke@gmail.com>
Role                 owner                         
AccountType          user                          
*

*
Name:  <>
Role                 reader                        
AccountType          anyone                        
*

screen shot 2016-07-02 at 1 23 40 pm

screen shot 2016-07-02 at 1 24 03 pm

@odeke-em odeke-em merged commit 5a0e201 into master Jul 2, 2016
@thebaddie
Copy link

Tested and working fine :)

@odeke-em odeke-em deleted the allowFileDiscovery branch July 9, 2016 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants